Luke100000 / ImmersivePaintings

Minecraft mod. Use your own paintings! Drag and drop! In Multiplayer!
GNU General Public License v3.0
13 stars 19 forks source link

recipe unlock advancement broken forever #80

Open superon opened 3 months ago

superon commented 3 months ago

Describe the bug the recipe/s is/are unlocked when you join a world rather than when it should be

To Reproduce start a world and view recipes in the recipe book

Expected behaviour the recipe should stay unlocked until the requisite items have been discovered

Additional context this seems to be in every version going back to 1.16.5 and can be easily fixed by replacing the condition "items" with the singular "item" afiak. ie: glow_painting.json

Luke100000 commented 3 months ago

It only affects 1.16.5; the syntax has changed:

      "conditions": {
        "items": [
          {
            "item": "minecraft:paper"
          }
        ]
      }

Thanks for reporting.

superon commented 3 months ago

ahha np