search

Luke100000 / minecraft-comes-alive

Replaces Minecraft's villagers with humans, who can be interacted with.
GNU General Public License v3.0
70 stars 49 forks source link

No Trades on modified Jobless Villagers #892

Open manusoftar opened 3 months ago

manusoftar commented 3 months ago

Describe the bug I don't know if I'm doing something wrong but whenever I approach a villager and open the interactions menu the Trade or Trading option never appears so I cannot trade... I'm using the mod on Minecraft Forge 1.20.1

To Reproduce Steps to reproduce the behavior:

  1. Get close to an MCA Villager
  2. Right click to open the interactions menu

Version MCA Version 7.5.8, Minecraft version 1.20.1, Modloader Forge

Luke100000 commented 1 week ago

If the trade button does not appear they do not offer to trade (e.g. guards or jobless villagers)

manusoftar commented 1 week ago

Not necesarily, on one of the versions of One Block, jobless villagers spawn (by data pack) and have trades setted. Also wandering villagers have trades even though they don't have a job.

El mié, 26 jun 2024 a las 12:37, Luke100000 @.***>) escribió:

If the trade button does not appear they do not offer to trade (e.g. guards or jobless villagers)

— Reply to this email directly, view it on GitHub https://github.com/Luke100000/minecraft-comes-alive/issues/892#issuecomment-2192016431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPOOA3Y23WVAZWXRPT73SDZJLN37AVCNFSM6AAAAABJ6FBXD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGAYTMNBTGE . You are receiving this because you authored the thread.Message ID: @.***>

Luke100000 commented 1 week ago

You should have mentioned earlier that you modded them. You can always bypass MCA by shift right clicking

manusoftar commented 1 week ago

I didn't mod anything, I'm using a map called Skyblock One Block which makes use of a data pack for it's functionality, it is in no way a mod, it's a map which starts with only one single dirt block that you break and it respaws but it gives you blocks and items and it begins to change the longer you mine it, but since it has to respawn and sometimes change it requires a data pack for the commands that it has to run, it's too complex for a command block or a collection of command blocks.

And wandering villagers are vanilla so no modding there neither.

El jue, 27 jun 2024 a las 2:11, Luke100000 @.***>) escribió:

You should have mentioned earlier that you modded them. You can always bypass MCA by shift right clicking

— Reply to this email directly, view it on GitHub https://github.com/Luke100000/minecraft-comes-alive/issues/892#issuecomment-2193712845, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPOOA7REOXUTBIUD5IXVLTZJONI3AVCNFSM6AAAAABJ6FBXD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTG4YTEOBUGU . You are receiving this because you authored the thread.Message ID: @.***>

Luke100000 commented 1 week ago

Please link the pack!

wandering villagers are vanilla

Do you mean wandering traders? Those are not villagers.

manusoftar commented 1 week ago

yes, sorry, my bad, I meant wandering traders, when I right click on a wandering trader I get the usual MCA dialog but the trade option is not enabled. I attached the datapack used on the Oneblock map.

El jue, 27 jun 2024 a las 2:46, Luke100000 @.***>) escribió:

Please link the pack!

wandering villagers are vanilla

Do you mean wandering traders? Those are not villagers.

— Reply to this email directly, view it on GitHub https://github.com/Luke100000/minecraft-comes-alive/issues/892#issuecomment-2193824658, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPOOA4MWX525GV5XXPOIGLZJORJ7AVCNFSM6AAAAABJ6FBXD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTHAZDINRVHA . You are receiving this because you authored the thread.Message ID: @.***>