LukeBotFanClub / LukeBot

He Needs It
1 stars 0 forks source link

Ongoing set reporting is in an inconvenient format #6

Open charlesepwilson opened 2 years ago

charlesepwilson commented 2 years ago

It would be better for those kinds of updates to only display the new info

charlesepwilson commented 1 year ago

Another potential improvement is to write the scores in a more standard format. The scores should be written between the names, and we should either always put Luke first, or always put the winner first. I prefer winner first: Luke 2-0 Someone TopSeed 3-2 Luke

If we could make the scores stand out by making them bold, or another colour or something that might also make it easier to read.

We could theoretically also put the seeds in the post similar to the PGstats upset twitter bot

tolxe commented 1 year ago

Currently, I believe the bot just directly takes the "displayScore" parameter fetched from the query. To my knowledge, I believe this follows the Start.GG format, which is always HigherSeed vs LowerSeed. The only exceptions to this are for Grand Finals, where in the first set will always display WinnersSide vs LosersSide, and in the reset, shows LosersSide vs WinnersSide.

charlesepwilson commented 1 year ago

Adding my conclusions from Discord here for discoverability: Now that @tolxe has added emojis (👑 and 🇫) to the end of the result lines, it makes more sense to always have Luke first. That way scanning over the right hand side you can easily see the opponent and result, instead of having to look at both the left and right side.