search

LukeCarrier / mkdocs-drawio-exporter

Exports your Draw.io diagrams at build time for easier embedding into your documentation
https://pypi.org/project/mkdocs-drawio-exporter/
MIT License
81 stars 9 forks source link

Deprecation warning when converting Draw.io images to svgs #17

Closed steinwelberg closed 4 years ago

steinwelberg commented 4 years ago

I get the following deprecation warning when building a Mkdocs website that contains draw.io images.

(electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".  It will change to be "true" in Electron 9.  For more information please check https://github.com/electron/electron/issues/18397
(node:58589) DeprecationWarning: Passing functions, DOM objects and other non-cloneable JavaScript objects to IPC methods is deprecated and will throw an exception beginning with Electron 9.
(node:58589) DeprecationWarning: Passing functions, DOM objects and other non-cloneable JavaScript objects to IPC methods is deprecated and will throw an exception beginning with Electron 9.

For every Draw.io image the above message is printed.

I'm using a Mac that has Draw.io 13.0.3 installed using Homebrew Cask.

My drawio-exporter config:

    - drawio-exporter:
          cache_dir: 'rendered-diagrams'
          format: svg
          sources: '*.drawio'
LukeCarrier commented 4 years ago

Hey Stein, thanks for reporting.

That error is being emitted from the Draw.io CLI itself, not the plugin. As it's an Electron warning I'd imagine it needs reporting at jgraph/drawio-desktop. Are you happy to raise it, or would you like me to?

I know the warnings are a little annoying, but I don't want to hide the output altogether as it can be indicative of configuration issues.

steinwelberg commented 4 years ago

Sorry, I thought it was due to how this plugin is interacting with the Drawio CLI. I'll raise the issue at JGraph 👍 .

Btw, I think it's a good choice to not swallow the output 😉.

LukeCarrier commented 4 years ago

Cheers @steinwelberg.

In #16 I'm looking at whether we can directly interact with the library to cut out the Electron dependency -- it'd make it much easier to work with in headless (e.g. CI) environments. I'm not sure when I'll get to this, though.

steinwelberg commented 4 years ago

That would be great! Although we are able to use it in our CI environment without a lot of effort (CircleCI).

I must say I love this plugin! It eases our workflow with Draw.io quite a bit!

For reference, here is the link to the ticket in the drawio-desktop repo: https://github.com/jgraph/drawio-desktop/issues/293