search

LukeCarrier / mkdocs-drawio-exporter

Exports your Draw.io diagrams at build time for easier embedding into your documentation
https://pypi.org/project/mkdocs-drawio-exporter/
MIT License
81 stars 9 forks source link

Fix quotation marks in f-string #60

Closed dolph closed 6 months ago

dolph commented 6 months ago

Closes: https://github.com/LukeCarrier/mkdocs-drawio-exporter/issues/59

ConnorTroy commented 6 months ago

It appears that there are several other f-strings with the same issue: https://github.com/LukeCarrier/mkdocs-drawio-exporter/compare/main...ConnorTroy:mkdocs-drawio-exporter:f-string-quotes

mriedem commented 6 months ago

Thanks for posting this. @LukeCarrier have you thought about running flake8 or some other static code check during CI runs?

LukeCarrier commented 6 months ago

Hey, thanks for fixing this. I'm happy to review any CI and release improvements but have barely enough time to maintain this as is.

In this case having a wider test matrix covering older Python versions prior to 3.12 would have caught this, and that's a quick win here (#61).

LukeCarrier commented 6 months ago

Have taken @ConnorTroy's linked diff above and added a missing __future__ annotation for the typings introduced in 0.9.0, both in #62. #61 should ensure I don't break everyone again in the next release :-)