search

LukeCarrier / mkdocs-drawio-exporter

Exports your Draw.io diagrams at build time for easier embedding into your documentation
https://pypi.org/project/mkdocs-drawio-exporter/
MIT License
81 stars 9 forks source link

Declare the plugin breaks mkdocs #7

Closed conjderumba closed 4 years ago

conjderumba commented 4 years ago

Hi!

I think the plugin is not working with mkdocs 1.1

If I declare the plugin, "mkdocs serve" don't start, and I get this error:

File "/Users/jma/.asdf/installs/python/3.7.6/lib/python3.7/site-packages/mkdocsdrawioexporter/init.py", line 2, in from .plugin import DrawIoExporterPlugin File "/Users/jma/.asdf/installs/python/3.7.6/lib/python3.7/site-packages/mkdocsdrawioexporter/plugin.py", line 9, in from mkdocs.utils import copy_file, string_types ImportError: cannot import name 'string_types' from 'mkdocs.utils' (/Users/jma/.asdf/installs/python/3.7.6/lib/python3.7/site-packages/mkdocs/utils/init.py)Is this plugin because if I remove it, mkdocs serve starts wihout problem.

Thanks

conjderumba commented 4 years ago

I made it work removing string_types from the import, and changing string_types for str.

Now I get some warnings, but it shows the diagram

LukeCarrier commented 4 years ago

@conjderumba I'm fairly sure this is related to #6. If you want to provide a PR that adds a warning to README.md I'll accept it. We'll be upgrading soon and I'll circle back to this then.