fix: Allow &mut references to be held by Next's state.

LukeMathWalker / pavex

An easy-to-use Rust framework for building robust and performant APIs

https://pavex.dev

Apache License 2.0

1.74k stars 59 forks source link

Closed LukeMathWalker closed 5 months ago

LukeMathWalker commented 5 months ago

Two issues combined:

We were running Next's state constructors through the same validation of user-registered constructors, but that's inappropriate. It's OK for them to hold &mut references, since they might be needed later in the pipeline.
There was a bug in our code to determine which request scoped components should be built. The set of prebuilt ids didn't include components that might later become relevant because they are "passed through" without being touched.

LukeMathWalker commented 5 months ago

/ok-to-test sha=29412bb

LukeMathWalker commented 5 months ago

/ok-to-test sha=b0e1c47