search

LukeMathWalker / wiremock-rs

HTTP mocking to test Rust applications.
Apache License 2.0
624 stars 72 forks source link

Fix newer clippy and rustdoc lints #136

Closed avandesa closed 10 months ago

avandesa commented 10 months ago

Description of changes:

This PR resolves clippy::format_collect and rustdoc::redundant_explicit_links, which should unblock the lint and doc CI steps for PRs.

The format_collect change is related to building the error messages when mock verification fails. Since it panics with the constructed strings directly, there currently isn't a way to unit-test their content without significant changes, but I did verify manually that the content doesn't change. I also verified that the documentation links being changed still work, though one of them changes from std::drop::Drop to core::drop::Drop.

As for the code coverage step, the entire actions-rs organization has been archived as of October of this year. I don't know what the recommended alternative is.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LukeMathWalker commented 10 months ago

Thank you very much! For code coverage, we need to move away from that action towards using tarpaulin directly—on my very long todo list.