LukeMathWalker / wiremock-rs

HTTP mocking to test Rust applications.
Apache License 2.0
617 stars 70 forks source link

Allow overriding `content-type` after `set_body_{bytes,json,string}` #63

Open JakubKoralewski opened 3 years ago

JakubKoralewski commented 3 years ago

The call to insert_header does nothing here:

let followed_page = ResponseTemplate::new(200)
    .set_body_string(followed_page_html)
    .insert_header("content-type", "text/html");

and instead requires doing this:

let followed_page = ResponseTemplate::new(200)
    .set_body_raw(followed_page_html.as_bytes(), "text/html; charset=utf-8");

I think this is confusing. Defaults are fine I guess, but it's weird that I can't set content-type to whatever I please to overwrite it.

Related

95th commented 2 years ago

Also, should the set_body_json really set the mimetype? A user should be able to set their own value anyway.