Selected verse doesn’t work when typed in the nav bar

[LukeMurphey]

It appears to remember the prior verse but doesn't update based on the updated verse number.

[LukeMurphey]

The verse to highlight gets set correctly, but then set to null in loadChapter(). The fetch sets it again to null because it isn't returning a verse_to_highlight.

[LukeMurphey]

Questions:

Is the correct URL being called with the verse to highlight set?

• It is calling the work for the chapter but doesn't include the verse information. It calls /api/work/new-testament/Galatians/2 instead of /api/work/new-testament/Galatians/2/20.

Why is the resolved reference not being used?

• loadChapter() is losing the highlighted verse. This is being called in useEffect()

What is the lifecycle of the reference to loading the page for a typed reference?

1. ReadingMenuBar: accepts key presses and checks the server to see if the reference is valid
2. ReadingMenuBar: if the user presses "enter", the reference is checked in checkAndGoToReference() and Reader::goToReference() is called to go to the new page
3. Reader::goToReference() accepts the request to go to a new reference and calls navigateToChapter() which calls updateHistory() to modify the URL and load the new path

Should the URL include the verse?

• Directly calling the URL with the verse selects it correctly
• get_work_page_info() on the backend handles this elegantly such that including the verse information should be fine
• So yes, the reference checking should be using the full verse

Can I fix this by having reference checking use the full URL?

• The divisions list returned by the API does not include the verse number though the URL does

What are the cases I need to test?

1. Unit tests
2. Navigate to a verse in another chapter via the input box
3. Navigate to a verse in the same chapter via the input box
4. Navigate to a verse in a book via the URL
5. Cases 2-4 with multiple works open

Observations:

• The resolve reference call does seem to get the correct reference.
• Adding referenceInfo.verse_to_highlight to the navigateToChapter() call in goToReference() fixes it:

    if(referenceInfo.verse_to_highlight) {
      updateHistory(requestedWork, secondWork, ...referenceInfo.divisions, referenceInfo.verse_to_highlight);
    }
    else {
      updateHistory(requestedWork, secondWork, ...referenceInfo.divisions);
    }

[LukeMurphey]

Here is the problem:

goToReference() calls updateHistory() but provides no way for the selected verse to be persisted.