search

LukePrior / nbn-upgrade-map

Interactive map showing premises eligible for the NBN FTTP upgrade program.
https://lukeprior.github.io/nbn-upgrade-map/
MIT License
100 stars 11 forks source link

Occasional issue when selecting older data in map view #297

Open lyricnz opened 7 months ago

lyricnz commented 7 months ago

From #293 #295 etc.

It's sometimes possible to see errors when navigating old history. For example, selecting the second-oldest Bli-Bli date gave me this:

image

The 404 URL is https://raw.githubusercontent.com/LukePrior/nbn-upgrade-map/7473d0340b2c0903276f1ecce2e3a10c3a35061f/results/QLD/bli-bli.geojson

And the commits URL is https://api.github.com/repos/LukePrior/nbn-upgrade-map/commits?path=results/QLD/bli-bli.geojson which does include 7473d0340b2c0903276f1ecce2e3a10c3a35061f

Are we using the wrong field in the JSON? (maybe commits direct to master, vs commits on a PR??)

lyricnz commented 7 months ago

The history page for that suburb https://github.com/LukePrior/nbn-upgrade-map/commits/main/results/QLD/bli-bli.geojson also shows the commit, but it looks like it deleted all these files

https://github.com/LukePrior/nbn-upgrade-map/commit/7473d0340b2c0903276f1ecce2e3a10c3a35061f

Maybe we need to special-case this sha out of the list? I don't know of another way to identify such case.