LukePrior / nbn-upgrade-map

Interactive map showing premises eligible for the NBN FTTP upgrade program.
https://lukeprior.github.io/nbn-upgrade-map/
MIT License
91 stars 10 forks source link

Add LOC ID to bubbles #320

Closed majibow closed 6 months ago

majibow commented 6 months ago

319 add loc id to bubbles

I was going to verify every single geo location has a loc id but its been 20 minutes since I started a git clone and I'm at 4%. Don't know if it needs to be protected e.g. ( "locID" in properties ? : properties.locID : ""). If you know off the top of your head then go for it. Otherwise, I will verify it when my git clone completes (tomorrow?).

majibow commented 6 months ago

If you know off the top of your head then go for it. Otherwise, I will verify it when my git clone completes (tomorrow?).

Judging from the generation script geojson.py a feature cannot be created without a locID therefore, this PR is totally safe.

LukePrior commented 6 months ago

Thanks