Open Jorvanus opened 4 months ago
Hmmmm that is really strange, I think something changed because on all the recent commits addresses are getting deleted.
I have paused the run but will need to investigate to find the root cause.
Not sure if @lyricnz has any idea but there haven't been any major changes on our end so looks like something might have changed on the NBN side?
Could this be due to several of the garbled LocIDs being trimmed? I have noticed between the 13/1 and 11/2 locations that had Loactions without a LocID infront have disappeared from the map. have attached photos for reference
Could this be due to several of the garbled LocIDs being trimmed? I have noticed between the 13/1 and 11/2 locations that had Loactions without a LocID infront have disappeared from the map. have attached photos for reference
Yeah, and if you plug that address into NBN, it acknowledges the address, but says more work needs to be done for this site to be connected.
All the ones I had a look at, all looked like sensible removals to me, as they don't have any active NBN connections to them.
Looking through the records while a lot of the addresses getting removed are ones without a valid LocID, some do have valid IDs.
The script should be using the listed locID in the results file and just querying NBN for updated details.
NBN has updated their autocomplete API to be less generous with matching it seems but I'm not sure why we are seemingly redoing this search...
Ok this is interesting it's a 404 error: https://github.com/LukePrior/nbn-upgrade-map/actions/runs/7946125610/job/21693534967
I think it has to do with extended_get_nbn_loc_id
I don't know if it's blocking us or something else because it works on reqbin, but not locally
https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k
curl -X GET https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k -H "Referer: https://www.nbnco.com.au/"
Can anyone confirm if this is same for them.
Not sure how you want me to test, but link doesn't work, and that line, gives me error in powershell.
That LOCID does work on the script I used to run myself. irm -Headers @{'referer'='https://www.nbnco.com.au/'} https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k | fl
timestamp : 1709024991023 servingArea : @{csaId=CSA300000010073; techType=WIRELESS; serviceType=Fixed wireless; serviceStatus=available; serviceCategory=brownfields; rfsMessage=Jul 2013; description=WCA-Willowmavin} addressDetail : @{latitude=-37.30807800000001; longitude=144.8932779; reasonCode=FW_SA; serviceType=Fixed wireless; serviceStatus=available; techType=WIRELESS; ee=False} addressSplitDetails : @{address1=150 High Park Rd; locality=Forbes; state=VIC; postcode=3764}
I've set it to rerun, seems the failing addresses have been fully removed from NBN so I guess not too much of an issue.
I think when the suburbs get updated again it will try to add them back with their new locID if available.
https://github.com/LukePrior/nbn-upgrade-map/actions/runs/8062401331/job/22022041834
Will revisit in a few weeks but hopefully it should stabilise, once it does can look into adjusting stats
Surely, there aren't just addresses that aren't there anymore? This doesn't look quite right.