search

LukeShortCloud / swgemu-server-packages

SWGEmu server Linux system packages that are easy to build and are reproducible.
GNU General Public License v3.0
2 stars 1 forks source link

Pin Repositories to a Specific Git Commit #4

Closed LukeShortCloud closed 5 years ago

LukeShortCloud commented 6 years ago

The RPM should use a specific commit instead of building from the latest master. This will help properly version the RPM and to provide a stable/usable package.

Latest commits as of today:

LukeShortCloud commented 5 years ago

These are the last commits for 2018:

LukeShortCloud commented 5 years ago

Work has started on this here: https://github.com/ekultails/swgemu-server-packages/tree/rpm_git_version

LukeShortCloud commented 5 years ago

When running through a build on Fedora 28 with GCC 8.3.1, a handful of class-memaccess warnings appear which result in the build failing.

(MMOCoreORB)$ make -j 4 build-cmake
...
/home/user/rpmbuild/BUILD/Core3-c8872ec05aae83066271cc7226c0eb6899b936e5/MMOEngine/include/system/util/ArrayList.h:633:33: error: 'void* realloc(void*, size_t)' moving an object of non-trivially copyable type 'class sys::thread::LockableTrace'; use 'new' and 'delete' instead [-Werror=class-memaccess]
       elementData = (E*) realloc(elementData, (elementCapacity = newCapacity) * sizeof(E));
                          ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
cc1plus: all warnings being treated as errors

This should be addressed by adding this argument to the build:

-Wno-error=class-memaccess
LukeShortCloud commented 5 years ago

Regarding the GCC warnings, I opened a separate issue here: https://github.com/ekultails/swgemu-server-packages/issues/6