search

LukeShortCloud / winesapOS

winesapOS - Game with Linux anywhere, no installation required!
GNU General Public License v3.0
871 stars 31 forks source link

Why not show an error if it fails #830

Closed GuestSneezeOSDev closed 2 months ago

GuestSneezeOSDev commented 3 months ago

Describe the bug or feature You could add an error message of what it has not been able to do instead of skipping/crashing on the device

Issue Type

To Reproduce not an issue

Expected behavior not an issue

Screenshots If applicable, add screenshots to help explain your problem.

System information (please complete the following information):

Additional context Displaying an error message may help the user decode/know what is causing issue and solve it

LukeShortCloud commented 2 months ago

@GuestSneezeOSDev What kind of crash are you encountering? Where are you encountering it?

Right now, the best crash recovery scenario we have is for when the graphics driver is broken. @wallentx helped implement a clever system to drop users in a TTY console that has a message containing hints for troubleshooting.

GuestSneezeOSDev commented 2 months ago

for example if the gui broke or anything was not working we can display an error message

LukeShortCloud commented 2 months ago

We handle the broken graphics driver use-case already.

The only other thing I can think of is to let the user know if anything failed during the first-time setup. We already have a very basic check for Internet access at the end. If there is no Internet, we let the user know that there was probably an issue. There is definitely room for improvement there.

wallentx commented 2 months ago

This is kind of a big gap that Linux in general has at the moment, and for all the various places I've poked around at, I'm not sure if there is consensus on where this kind of thing should/could be handled at in a way that isn't some 1-off hand-rolled solution for each distro.

There may be some hope here... but this might only be accounting for kernel panics - https://www.phoronix.com/forums/forum/software/general-linux-open-source/1458575-linux-6-10-preps-a-kernel-panic-screen-sort-of-a-blue-screen-of-death/

https://github.com/canonical/lightdm/pull/340

https://github.com/systemd/systemd/issues/30804