search

LukeShortCloud / winesapOS

winesapOS - Game with Linux anywhere, no installation required!
GNU General Public License v3.0
883 stars 30 forks source link

[install] Add support for KDE Connect #857

Closed LukeShortCloud closed 1 month ago

LukeShortCloud commented 1 month ago

KDE Connect allows connecting a phone for seamless integration between that and the KDE Plasma desktop environment. Originally suggested by @GuestSneezeOSDev to add.

Related: https://github.com/LukeShortCloud/winesapOS/pull/853#issuecomment-2241282746

GuestSneezeOSDev commented 1 month ago

Package kdeconnect

GuestSneezeOSDev commented 1 month ago

i could add this package to my PR

LukeShortCloud commented 1 month ago

Sounds good, yes and thank you!

GuestSneezeOSDev commented 1 month ago

i will see what i can do

GuestSneezeOSDev commented 1 month ago

I think the issue can be closed

GuestSneezeOSDev commented 1 month ago

I Have added 3 Lines of codes which will install KDE-Connect which will install KDE-Connect making it supported but i still need the firefox extension for KDE-Connect

GuestSneezeOSDev commented 1 month ago

Fixed in Pull request : https://github.com/LukeShortCloud/winesapOS/pull/853/ Fix : https://github.com/LukeShortCloud/winesapOS/pull/853/commits/3de6af9c46218652b20370d9544414b18681d123

LukeShortCloud commented 1 month ago

Thanks for your contribution! I finished the KDE Connect implementation by adding a test, having it only install as part of the KDE Plasma desktop environment (it's very complicated to run on other DEs), and added your name to the list of contributor's via this commit: https://github.com/LukeShortCloud/winesapOS/pull/898/commits/294f6a9f34eec3abca32537b03835bf01046c1d1

GuestSneezeOSDev commented 1 month ago

Your welcome @LukeShortCloud I am glad to help the winesapOS project move forward