LukeSkywalker92 / TeleFrame

TeleFrame - a digital picture frame for telegram
MIT License
92 stars 28 forks source link

File deletion #53

Closed Trenar closed 4 years ago

Trenar commented 4 years ago

As requested for #51, I added a parameter to the config file. This makes this PR non-compatible with previous releases

(Sorry, if I made a mistake with this PR, I'm not very familiar with the git-workflow...)

LukeSkywalker92 commented 4 years ago

I think we should wait for #46. can you try to merge #46 into your branch to see if there are conflicts?

LukeSkywalker92 commented 4 years ago

46 is merged to develop. so you can fix the conflicts now

Trenar commented 4 years ago

Conflicts are fixed, should be mergeable now. However, I couldn't test it in a raspi, only on my Linux machine w/o touch support but I think it makes no difference for testing this feature.

LukeSkywalker92 commented 4 years ago

I’m going to test it later, but pleas add an entry to the README.md.

Trenar commented 4 years ago

Ready for merge

gegu commented 4 years ago

@Trenar please add a documented entry for the new configuration option to the defaultConfig.js, then I will merge your PR

Trenar commented 4 years ago

Done. Thanks for your work :)

And merry Christmas :)