search

LukeSkywalker92 / TeleFrame

TeleFrame - a digital picture frame for telegram
MIT License
92 stars 28 forks source link

Whitelist dialogue #74

Open LukeSkywalker92 opened 4 years ago

LukeSkywalker92 commented 4 years ago

Maybe we should show a dialogue when the bot receives a "hi" from a non whitelisted chat. This dialogue could show a "add 'sender name' to whitelist" button. This would be one more step towards a texteditor free configuration. We should wait with this for #66.

Trenar commented 4 years ago

This seems a bit unsafe to me.. What is the whitelist for, if anybody sending "hi" can add himself to it? It makes only sense if the whitelist is still empty (maybe directly after installation) and the admin ist starting to set up the software.

IMHO, the bot should offer the opportunity to request access and an admin of the bot would need to accept that user/chat-ID (asking for the admin mode #35 with some more improvements...). However, if you are unlucky, many people will send you random requests if your bot is easy to find...

gegu commented 4 years ago

I think we could make that work.

But then we would also need a blacklist in which the rejected chatid's would be stored.

@Trenar, the sender would have to be on site so that he can confirm himself by touching 'Confirm' on the TeleFrame screen.

Trenar commented 4 years ago

But if he isn't on site but requests access and my grandma presses okay, not understanding what's happening? I'd prefer the admin to actively whitelist chat ids

gegu commented 4 years ago

Yes, I am familiar with the problem that technically less experienced people always like to confirm with "Yes I do". 🙈 But this feature has to be enabled in the config anyway and should not be active by default.