LukeSkywalker92 / TeleFrame

TeleFrame - a digital picture frame for telegram
MIT License
92 stars 28 forks source link

Support receiving images/videos sent as subtype 'document' #85

Closed gegu closed 4 years ago

gegu commented 4 years ago

Images and videos are handled further if they were sent as documents. So it is possible to output animated GIF's as suggested in #78. Images in PNG and GIF format which use transparency can also be sent.

Trenar commented 4 years ago

Wow, you're fast. Thanks a lot, I'll test it as soon as I get my fingers back on a TeleFrame given away on Christmas :D

Trenar commented 4 years ago

Nice implementation @gegu . However, an animated .gif is shown exactly as long as interval is chosen. That means, if the gif is shorter, the very last frame is held until interval is reached and if the gif is longer, it is simply cutted. This may not be too bad for an interval of (lets say) 30 seconds, but should be handled (in the renderer?) just as a video playback

Trenar commented 4 years ago

New tests showed that this behavior (last frame freezed as long as interval or video cropped) also shows up for mp4 videos... Could be related to #86 and the other renderer?

gegu commented 4 years ago

Yes, in #86 the duration of the video was not taken into account. This was fixed.