search

LukeSkywalker92 / TeleFrame

TeleFrame - a digital picture frame for telegram
MIT License
92 stars 28 forks source link

Sunfounder screen config #94

Closed Trenar closed 4 years ago

Trenar commented 4 years ago

closes #93

gegu commented 4 years ago

We can't implement it that way. If the pin has been adjusted in the screen configuration, TeleFrame can no longer be updated without manual intervention.

In #97 I provided the requirements for dynamic initialization. Please let me know if this meets your requirements. If so, then I will merge this PR, #85 and #90

sohamakl commented 4 years ago

Thanks for the support. For me it's a good solution.

Trenar commented 4 years ago

Fine for me as well. @sohamakl , did you already test it?

sohamakl commented 4 years ago

Yes, but with an old release of TeleFrame and manuel changes. In my case I had to change the bash command from exec("bash ../tools/screen_switch.sh" to exec("bash ./tools/screen_switch.sh"

Sunday evening I can continue testing.

Trenar commented 4 years ago

Okay, that one is fixed.. I can't test display specific code anymore since all my three entities of the frame are gone :cry: The last one left me today.. Now I can only test on my notebook. btw @gegu is there a possibility to use the touchbar without a touchscreen but with the cursor?

sohamakl commented 4 years ago

Off topic but could you explain how to start this project on a windows pc.

Trenar commented 4 years ago

I can't help with Windows, und Linux (Ubuntu) I just clone via Terminal (run git clone https://github.com/LukeSkywalker92/TeleFrame, change to that newly created directory, create a config.json and then run npm install and npm start.

sohamakl commented 4 years ago

Okay, l’m using windows :-(

LukeSkywalker92 commented 4 years ago

I can't test display specific code anymore since all my three entities of the frame are gone 😢 The last one left me today.. Now I can only test on my notebook. btw @gegu is there a possibility to use the touchbar without a touchscreen but with the cursor?

You just need to open the dev tools in electron (ctrl+alt+i) and open the device toolbar, then clicks are treated like touches.

LukeSkywalker92 commented 4 years ago

Okay, l’m using windows :-(

It should be the same but you need to install git (https://git-scm.com)

mistau commented 4 years ago

While I cannot test this one as I don't own the according display the integration looks perfect.

gegu commented 4 years ago

@Trenar do you want to adjust your PR so that the configuration is adopted?

Trenar commented 4 years ago

Yes, I'll do if I find the time

gegu commented 4 years ago

Okay, I didn't mean to stress you out ☺️

Trenar commented 4 years ago

Finally.. I hope I made no mistakes, it's been a while...

gegu commented 4 years ago

👍 Looks good. Merged