use #!/usr/bin/env bash instead of #!/bin/sh
use set -euo pipefail to enable strict error handling printf instead of echo because printf is more reliable
Use 2>&1 instead of >/dev/null to redirect both stdout and stderr to the same location
Use || exit 1 instead of >/dev/null 2>&1 to handle command failures. This will cause the script to exit with a non-zero exit code if the command fails. Instead of just ignoring the error.
Misc. optimizations
Changes
use
#!/usr/bin/env bashinstead of#!/bin/shuse
set -euo pipefailto enable strict error handlingprintfinstead ofechobecauseprintfis more reliableUse
2>&1instead of>/dev/nullto redirect both stdout and stderr to the same locationUse
|| exit 1instead of>/dev/null 2>&1to handle command failures. This will cause the script to exit with a non-zero exit code if the command fails. Instead of just ignoring the error.Misc. optimizations