LukeSmithxyz / dwm

Luke's build of dwm
MIT License
809 stars 537 forks source link

Bump to 6.4 #226

Closed iStagnant closed 1 year ago

iStagnant commented 1 year ago

I repatched everything this should be working fine please test.

iStagnant commented 1 year ago

If i press SUPER+F9 it runs mounter i choose a phone it quits, i run mounter from the terminal works exactly as it should,i choose a usb from SUPER+F9 it works fine, i do the same in your build works fine, i go to the commit before the bump it works. Do you know how i can see the logs to investigate this? Edit: It wasn't only in my build i just cloned your build without merging i'm dumb.

iStagnant commented 1 year ago

Nvm i found the problem, but i can't fix it since I'm no c wizard.

(notify-send:4968): GLib-WARNING **: 01:22:43.471: In call to g_spawn_sync(), wait status of a child process was requested but ECHILD was received by waitpid(). See the documentation of g_child_watch_source_new() for possible causes.

(notify-send:4968): GLib-WARNING **: 01:22:43.473: In call to g_spawn_sync(), wait status of a child process was requested but ECHILD was received by waitpid(). See the documentation of g_child_watch_source_new() for possible causes.
Error spawning command line “dbus-launch --autolaunch=d6f8a102bb9d86ed8104e065636e3191 --binary-syntax --close-stderr”: Child process killed by signal 32

This is the error that's outputed from dwm, it's caused by notify-send and after searching for a bit i found that this commit is what caused it and like i said this only happens when mounter is executed by SUPER+F9 and the problem isn't while mounting the phone only, it quits when mounting the phone but anything that sends a notify-send command won't work.

If you can fix this then please do if not I'll just remove the commit that caused the problem.

LukeSmithxyz commented 1 year ago

This is caused by it having to call a sudo subprocess. Happens with other scripts bound needed sudo. Not sure if there is some way of avoiding this while keeping the commit.

Edit: Or I should say, that is another issue by this commit. I'm going to go ahead and merge this with that commit absent.