search

LukeSmithxyz / emailwiz

Script that installs/configures a Dovecot, Postfix, Spam Assassin, OpenDKIM Debian web server
GNU General Public License v3.0
1.82k stars 301 forks source link

Add safeguards to script #308

Closed tfasano1 closed 10 months ago

tfasano1 commented 10 months ago

DNS records that point at least your domain's mail. subdomain to your server's IP (IPv4 and IPv6). This is required on initial run for certbot to get an SSL certificate for your mail. subdomain.

Someone can forget to setup their AAAA record and the script will still appear to work (certbot doesn't need ipv6). This pr adds a safeguard to include ipv4 and ipv6 into the spf record. Martin found by adding it he could send to gmail even without the AAAA record.

I guess what's happening here is some people are not watching the video tutorial so they skip over adding AAAA record since it's not explicitly stated to do so in the text based guides.

LukeSmithxyz commented 10 months ago

Just to be clear, supposing they have not set an AAAA record, this will create a blank ip6 entry in the record. Will this fix the problem as well?

tfasano1 commented 10 months ago

Just to be clear, supposing they have not set an AAAA record, this will create a blank ip6 entry in the record. Will this fix the problem as well?

Now that you mention it, it would be blank and that certainly wouldn't fix anything. One other way to go about this is to have the script exit with a helpful warning if it detects you haven't set up your A/AAAA records or other records for that matter. I see it's at the top of the script, but probably best to include in the prereq instructions "Add A and AAAA records with your DNS registrar". I've added some of these record checks in latest commit.