search

LukeSmithxyz / lugo

Luke's Hugo Theme
184 stars 64 forks source link

Option to change the name of the RSS output file #5

Closed ghost closed 2 years ago

ghost commented 2 years ago

Hi, this is my first PR ever.

This attribute in the config.toml will let you change the name of the default output file index.xml, depending on your baseName, to something like rss.xml or feed.xml.

I think many people would prefer a name like this over the default one. Let me know what you think!

ghost commented 2 years ago

This PR has no reactions, is there anything wrong or stuff that needs to be changed?

Also, it says This branch has conflicts that must be resolved, because there is a new commit to the README.md file. Is this a problem or rather irrelevant? Sorry again, I'm new.

LukeSmithxyz commented 2 years ago

I see no reason to force people to deviate from the Hugo default.

ghost commented 2 years ago

I understand. I thought at least giving them the option to change it would be a good idea, as I had difficulties finding out how you do that by myself.

A "compromise" would be to leave the default at index.xml defined through the baseName instead of my proposed rss.xml.