search

LukeSmithxyz / voidrice

My dotfiles (deployed by LARBS)
GNU General Public License v3.0
4.27k stars 1.21k forks source link

Fix pdf and plain text previws in lf #1369

Closed thirtysixpw closed 10 months ago

thirtysixpw commented 10 months ago

Pdf previws don't appear because are generated with wrong filename.

Plain text previws with bat don't respect terminal theme and have annoying border.

LukeSmithxyz commented 10 months ago

The PDF previews are working fine on my machine as pdftoppm automatically appends .jpg to all filenames, thus this addition creates files that are filename.jpg.jpg that do not function.

Not sure if you are on a different version of pdftoppm or something, but this is 23.10.0.

thirtysixpw commented 10 months ago

Yes, pdftoppm worked fine, I probably messed something up in another place. Mine is on 23.10.0 version too.

thirtysixpw commented 10 months ago

Reverted pdf cache filename, now it works fine.

This pull request also fixes plain text previews, done with bat, forcing them to use terminal theme.