(Any) neovim color scheme looks like absolute trash - Githubissues

LukeSmithxyz / voidrice

My dotfiles (deployed by LARBS)

GNU General Public License v3.0

4.27k stars 1.21k forks source link

(Any) neovim color scheme looks like absolute trash #184

Closed LukeSmithxyz closed 5 years ago

LukeSmithxyz commented 5 years ago

Now that these dotilfes are using neovim, there's a problem I can't solve that occurred between the update of neovim-0.3.1-2 and neovim-0.3.4-2. Specifically, the color scheme, any color scheme is mangled and looks terrible. On the left is the desired appearance as in vim or in the earlier neovim, on the right is with the current binary:

https://lukesmith.xyz/pix/nv1.jpg

I've scoured commits and documentation, but I can't pinpoint what caused this or what settings can mitigate it.

This problem is not specific to st. I've tried urxvt and alacritty as well and they have the same problem.
I've also tried :set termguicolors, which does change the shade to a slightly uglier color, but doesn't do what I need.
I've also changed X colorschemes. It's clear that whatever is happening, neovim is distorting whatever colors you give it, but it is reading my colors set in Xresources. See the solarized example below:

https://lukesmith.xyz/pix/nv2.jpg

I consider this issue urgent and am keeping neovim downgraded until I figure out what's wrong. If no one can lead me to a fix, I'll be reverting LARBS back to vanilla vim or gvim for a color scheme less vomit-inducing.

EDIT: apparenly github doesn't allow offsite images...

luukvbaal commented 5 years ago

Interesting, for me neovim works fine (switched to it a few months ago) works fine but I can't exactly say what is different in my dotfiles as I have been manually applying commits from the commit rss feed since I have too many local conflicts to be able to pull from the repo.

luukvbaal commented 5 years ago

Yeah same result using your Xresources. So I guess the difference being that I use my pywal scheme in neovim (colorscheme wal) prevents this issue from occurring.

luukvbaal commented 5 years ago

Seems like it is using colors from your .Xresources just not the ones you're used to seeing I guess.

luukvbaal commented 5 years ago

Seems like :colorscheme peachpuff is what you're looking for or not? I guess that was what you were using in vim previously or it might be vim's default somehow but I doubt that.

LukeSmithxyz commented 5 years ago

I have never set a vim color scheme before. peachpuff does look similar to the original scheme, but the yellow is more garish. I'll probably set peachpuff as the default for the time being.

Do you know if they had switched the default color correspondence?

luukvbaal commented 5 years ago

No idea but seems to be the case then.

LukeSmithxyz commented 5 years ago

Oh well. What a bother. I'm more confused as to why this only happened to me/LARBS...

dawidpotocki commented 5 years ago

@LukeSmithxyz does set bg=light fix that for you?

They changed default to use light colors by default, pretty stupid decision, but whatever..

See https://github.com/neovim/neovim/issues/9455

LukeSmithxyz commented 5 years ago

Wow, thanks! That's what it is exactly. Yeah, I agree, that's a moronic decision. Oh well...