LukeWasTakenn / luke_garages

Super lightweight FiveM resource that adds garages and impounds for the ESX Legacy framework
GNU General Public License v3.0
33 stars 37 forks source link

Config option for society jobgarage #57

Closed Vumono closed 2 years ago

Vumono commented 2 years ago

Added config option for jobgarages to have a 'shared' garage containing all vehicles in that garage by people with the job

LukeWasTakenn commented 2 years ago

Wouldn't this just cause issues where a player can take out another player's owned job vehicle?

Vumono commented 2 years ago

I dont think it will be an issue because then it's society vehicles. So all job vehicles are society owned. Might become an issue when in impounds tho, was going to have a look at it later again for a better way or config option per 'job' garage

LukeWasTakenn commented 2 years ago

Any update on this?

Vumono commented 2 years ago

Yes, fixed the impounding and added the option for people with same job to put away the vehicle in the garage

Vumono commented 2 years ago

As you said tho, all people with same job will be able to pull out all the jobvehicles. That's why it's society jobgarage

LukeWasTakenn commented 2 years ago

As you said tho, all people with same job will be able to pull out all the jobvehicles. That's why it's society jobgarage

I feel like that kind of defeats the point of owning a job vehicle if someone else can pull your own vehicle out and stuff.

Vumono commented 2 years ago

Well, I think we might have a different understanding of a job vehicle. What Im using the job vehicle garage for is purely to have jobs like police and ambulance have only a couple vehicles in their garage for everybody to use. Which opens up the possibility for police to earn money and invest in better/more cars and such. But I understand that's not something everybody wants on their server

Marc85BPG commented 2 years ago

in a job, like ambulance/police, doj, etc. you should not be the "owner"...the "owner is the hospital-police station. you work in this job, so everyone should take a vehicle out like vumono did this. so i totally agree what vumono said :)

LukeWasTakenn commented 2 years ago

I think I'll do this as a base option then, instead of it being a config option