LukeWoodward / SplitsBrowser

Orienteering results analysis
GNU General Public License v2.0
13 stars 9 forks source link

Question marks in labels on right of graphs #15

Closed Maprunner closed 10 years ago

Maprunner commented 10 years ago

I've managed to integrate Splitsbrowser with RG2 and most things are looking good. It is on the live HH site. Once you have selected an event you get a Splitsbrowser logo in the icon bar at the top right. Click on that and you get Splitsbrowser in a new window.

The results are included as javascript declarations in the html file. The only thing that looks a bit odd is that the name labels shown on the right of the graphs have three question marks at the end.

I'm guessing this is a problem with the results format I am passing, which is nominally Sportident CSV format. Any clues what is wrong? rg2-three-question-marks

LukeWoodward commented 10 years ago

Hi Simon,

I've had a quick look at one event, and it looks like you're duplicating the finish punch time amongst the control data at the end of each row. If you take a look at the results table (I don't know which event your picture comes from, but I saw this problem on this one), you'll see that all competitors have a finish split of 0:00.

I don't know where you're getting the data from, but I would recommend removing the duplicate finish time from the control data if you can. SplitsBrowser does not expect to find the finish time amongst the control data.

The time loss calculations for the finish (see here) don't make sense, as all splits to the finish are zero and all time losses involve dividing zero by zero, hence they appear as '???'.

Yours,

Luke

Maprunner commented 10 years ago

Luke,

Thanks. Data is coming from the Routegadget files, which include a finsih split. I've updated the API which has fixed the display.

Should be able to roll this out to all routegadget.co.uk sites within the next few days.