LukeWoodward
commented
7 years ago On reflection it seems only the OE CSV reader is affected by this. This is the reader that is most likely to think that a file appears to be of its format and then later find that it isn't. For the others, the situation is less likely to suggest we've mis-identified the file and more likely to suggest that it's a very poor file of the specified format.
Additionally, the HTML format reader doesn't generate warnings, and the triple-column CSV reader doesn't generate warnings for the first competitor in a class (and hence can never do so for all competitors).
Given that the fix has now been applied to the OE CSV reader, I'm happy to consider this as done.
Event 9560 on splitsbrowser.org.uk presently loads but a warning is issued for every competitor in the file, and so no data can be viewed.
It's not clear what type of event the data in this file is for. However, it certainly does not contain split times so SplitsBrowser cannot reasonably be expected to view the data in it. In this case it would be better for SplitsBrowser to reject it as unrecognised.
If the end result of parsing a file is that no competitors are read, but warnings have been issued, it is likely that the file being loaded is not of the format that the parser thought it was. The parser should then reject the file as not being of the correct format.