LukeWoodward / SplitsBrowser

Orienteering results analysis
GNU General Public License v2.0
13 stars 9 forks source link

Odd graph display on event 10439 #58

Closed LukeWoodward closed 6 years ago

LukeWoodward commented 6 years ago

Event 10439 on splitsbrowser.org.uk has some odd behaviour on the Y-axis of the graph. The splits graph for the ALEVIN FEMENINO class shows decimals going off the left hand side of the graph.

The course in question has a single starter, who didn't complete. Also their graph line starts at the top left and finishes at the bottom-right, whereas I would expect it to finish at the top-left.

LukeWoodward commented 6 years ago

The problem appears to be a calculation of the Y-range of chart data. With the class mentioned above, the code should ideally produce two equal values for the Y-range and hence cause some special-case handling to substitute a difference of 1 for the current zero difference. However, the values at each end of the range are floating-point numbers and in some situations (such as this) the difference is a tiny fractional number rather than zero. The special-case handling should therefore be adjusted to cope with floating-point noise.