search

LukenSkyne / Minecraft-Ping-Wheel

a minecraft mod for fabric & forge which allows players to temporarily mark locations and entities
MIT License
21 stars 11 forks source link

[Feature Request]: play a sound when the ping lands on certain blocks #36

Open Crafttim opened 7 months ago

Crafttim commented 7 months ago

this feature is based on the game Deep Rock Galactic, where a Dwarf pings a gold piece and says "we are Rich!"

this could be by default off and changed to custom "voice lines / audio files".

Crafttim commented 7 months ago

https://www.youtube.com/watch?v=NDFw9ubrlrg

LukenSkyne commented 7 months ago

Sounds like a fun idea.

How would you expect this to be configured? Maybe have a file with blockId -> sound mappings, but the actual audio files have to be supplied by a resource pack. Also this would require for the packet structure to be changed, since there is currently no target block information sent with pings.

Crafttim commented 7 months ago

return: block minecraft:dirt == resourcepack.zip\assets\ping-wheel\sounds\minecraft\block\dirt.ogg return: item minecraft:dirt == resourcepack.zip\assets\ping-wheel\sounds\minecraft\item\dirt.ogg

default sound ping-wheel:block == resourcepack.zip\assets\ping-wheel\sounds\ping-wheel\block.ogg default sound ping-wheel:item == resourcepack.zip\assets\ping-wheel\sounds\ping-wheel\item.ogg

instead of a file which lists all items/blocks and applies a sound to them. It would make it easier to just search for a available sound in "assets\ping-wheel\sounds\*modname*\*item | block*\*Block-id*", then if failed just default back to a default ping sound.

the mode could be selected with a dropdown/list: Ping | Resourepack / Ping | Narrator(narrates this:"block minecraft:dirt")