LukenSkyne / Minecraft-Ping-Wheel

a minecraft mod for fabric & forge which allows players to temporarily mark locations and entities
MIT License
21 stars 11 forks source link

[Feature Request]: Ability to ping Distant Horizons chunks. #39

Open DeisDev opened 5 months ago

DeisDev commented 5 months ago

Not sure how this would be implemented but currently the behavior is that it will ping up to how many vanilla chunks are loaded in. If you try to ping anything further than the vanilla render distance, it simply wont.

LukenSkyne commented 5 months ago

Hey, as far as I know, Distant Horizons works similar to Nvidium, where terrain only lives in GPU memory (see here). As you might have guessed, the chunks are not actually loaded and therefore can't be raycasted to.

MCRcortex commented 5 months ago

Distant horizon api has support for raycasting into its terrain if i remember correctly

LukenSkyne commented 5 months ago

Distant horizon api has support for raycasting into its terrain if i remember correctly

Good to know, I'll look into it!

LukenSkyne commented 5 months ago

I have drafted a proof of concept for an integration of the DH Api into Ping Wheel.

Unfortunately, with the latest version of Distant Horizons (v2.1.0a), the raycast can no longer respond within a reasonably short duration, due to heavy performance optimizations of the mod. From my testing, I've had inconsistent access times between 0.5 and 20 seconds on good hardware and up to a minute on a slower machine. With version 2.0.1a this was usually less than a few milliseconds at most.

I've talked to the project owner about the issue on Discord, but we can't tell if and when this will be addressed.