[Feature Request] Add ability to enable/disable enchantments from appearing in enchantment tables, treasure, villagers, mob equipment and loot

[elhertz]

Hey! I've requested some of this features to a couple of devs before. I think it should greatly improve the experience with the mod.

So, in my use case, I like to make some of the new enchantments as treasure-only or as a custom boss' loot to make them rare, some can be crafted with NbtCrafting, others can be traded with villagers, then the rest that I consider not that broken/OP can still be obtained in the enchantment table.

Now, this request is super specific and it would only benefit me (a server owner/modpack maker) because I don't think casual players would make use of it. Still, I think it's a really good tool for us (server owners/modpack makers) to give our players a better experience with enchanting.

Specific info about my request:

• General: ability to disable enchantments from initializing (I don't know if that's possible but it would be a good way to prevent enchantments even from appearing in mods like REI)
• Enchantment table: ability to enable-only/disable certain enchantments from appearing in the enchantment table.
• Treasure: ability to enable-only/disable certain enchantments from appearing in treasure loot tables. There's this function that minecraft uses to assign a random enchantment to an enchanted book, armor, weapon, or tool. It includes all the enchantments afaik. It's called "minecraft:enchant_randomly". I use lots of mods/datapacks that add new structures and mobs and it's a pain having to manually edit 500 loot tables everytime I add new enchantments.
• Villager trading: ability to enable-only/disable certain enchantments from appearing in villager trades.
• Mob equipment and mob loot: enable-only/disable certain enchantments from appearing in mob equipment and loot (I remember there was this mod that allowed you to disable enchantments but they would still appear in mob armor and weapons so I had to deal with the fact that you can't even disable them using loot tables)

Note: what's that about "enable-only"? With that setting you wouldn't need to go and disable enchantments one by one when for example you only need it as "treasure only".

Here are some old requests I made to other enchantment mods, the code might be useful to you: https://github.com/StrikerRockers-Mods/VanillaTweaksFabric/issues/6 https://github.com/Tigereye504/spellbound/issues/12 https://github.com/herb-mc/extra_enchants/issues/12

This it a lot of work so I wouldn't mind if you just want to keep your mod as simple as possible. Feel free to ask me more questions. Sometimes my english makes no sense. Thanks!

edit: fixed some typos

[Luligabi1]

It's been requested a few times but it's currently on hold until Omega Config updates.

General: ability to disable enchantments from initializing (I don't know if that's possible but it would be a good way to prevent enchantments even from appearing in mods like REI)

That's generally a bad, bad idea. If the server has an enchantment disabled but the client doesn't or vice-versa, the client wouldn't be able to join at all.

I'll take the other requests in consideration but I can't say they'll be implement or not until I see how complicated it'd be.

[elhertz]

That's generally a bad, bad idea. If the server has an enchantment disabled but the client doesn't or vice-versa, the client wouldn't be able to join at all.

I was talking from a modmaker point of view there. I'm able to sync my users' config files. But yeah, it'd be bad.

[Luligabi1]

Good news - I'm working on this for the 1.19.3 update. My solution to the issue was to allow configuring if enchantments can appear on a Villager's book offer, loot tables and as a treasure. Disabling all 3 options renders the enchantment completely unobtainable. There is the issue of already existing worlds, but I believe the impact should be relatively minor as it's not so uncommon to upgrade your modded worlds.