Luligabi1 / Incantationem

Minecraft mod for additional, fun and (hopefully) balanced enchantments
Other
3 stars 3 forks source link

New Enchantments, A New Curse, And A Bug Fix #27

Closed Superkat32 closed 1 year ago

Superkat32 commented 1 year ago

Hello! I've added 5 brand new enchantments, a good amount of which are based on #2 , a new curse, and a bug fix for the Bane of The Swine enchantment. I'll describe each item in detail in a minute, but I wanted to point something out before doing so. As you read through the commits(which have proper messages this time!!! :D :D), you'll notice that I was consistently inconsistent with my arranging of enchantments, and that I continuously refactored the placement of enchantment registries and enchantment config arrangements. When you are looking through the commits one by one(if you do), and you notice that an enchantment isn't in the right spot, there is a chance I fixed it later on(if not then I can fix that). With that said, here are the new enchantments, all formatted in the same way you have the wiki, so you can copy-paste(for the most part)! Happy Modtoberfest!

Bane of Ender

Loot & Scoot

Critical Strike

Deflection

Explosive

Curse of Shrieking

That is the end of the list of enchantments and curse. I also fixed a bug where it was possible to stack multiple Bane of The Swine enchantments on a single weapon. If you want me to change or straight up remove any of the enchantments I've added, I can do that. I made sure to keep each enchantment in its own commit so that it was easy to remove(hopefully). One thing I would like to note is that I didn't really change the getMinPower and getMaxPower methods for the enchantments I added. I'm not actually really sure what they are for, but I have a feeling they are used to determine the probability of an enchantment being in a loot table. If you need me to change that(or anything else for a balance change), then I can do that as well.

Superkat32 commented 1 year ago

Alrighty! Thanks! I tried to not make nitpick changes while not over worrying about it(to keep the development speed going) because I noticed that I keep changing small things when I really shouldn't be. But I guess I still have more to learn 😅 /lh