Luligu / matterbridge-zigbee2mqtt

Matterbridge zigbee2mqtt plugin
https://github.com/Luligu/matterbridge-zigbee2mqtt/blob/main/README.md
Apache License 2.0
78 stars 9 forks source link

z2m plugin debug bug #35

Closed copystring closed 4 months ago

copystring commented 5 months ago

For the debug: - the frontend log has his own system and display only matterbridge and plugins:

- the console log displays the matterbridge and matter.js log with the level you select here or from the command line: image - the console log also displays the plugin log with or without debug depending on this: image

Originally posted by @Luligu in https://github.com/Luligu/matterbridge-zigbee2mqtt/issues/33#issuecomment-2187392721

Please take a look at this video and let me know if the debug messages in the home tab are intended.

https://user-images.githubusercontent.com/1298861/342930557-befa3572-582b-4bf7-be4f-c17ca3e9ca91.mp4

copystring commented 5 months ago
  • the small log in the Home page shows always everything.

This behavior is very confusing. As you know, I have a lot of devices and the little log shows way too many messages, making it hard to read with all those debug messages I don't need.

From a user experience, there are way too many ways to enable/disable debug logs.

If you ask me, one log type should be globally selected and then one for each plugin. Everything else is too much.

copystring commented 5 months ago

Try this video because the upload to GitHub did not work. https://youtu.be/vJrLQ3LRnrI

Luligu commented 5 months ago

What would you like to have and not to have? What would you like to change?

copystring commented 5 months ago

One option to globally change the log type and one option to enable/disable debug for each plugin should be enough. I think this could best be done in the settings tab of matterbridge or in the log tab, but not both, or at the least make the two settings synchronized. Having it in both tabs is what I think is confusing.

Another thing that confused me is the log in the home tab shows different content than the log in the log tab. How would any user know this is the expected behavior? The log in the home tab does not have much room and sometimes the debug messages use up a lot of room making it hard to follow. See my example below. Maybe make the log area taller if a user really wants debug messages in the home tab.

image

Luligu commented 4 months ago

Hi, I finally finished the refactor of loggers. It will be in the latest soon (needs a few publish from all plugins so it will take a few days..). If something else is not clear in a week open another issue please. Thanks.

copystring commented 4 months ago

Thank you! I'll have a look when you're finished