search

Lullabot / amp-library

Convert HTML to AMP HTML and report HTML compliance with the AMP HTML specification
Other
382 stars 181 forks source link

Allow multiple versions of diff and PHPUnit #219

Closed alexpott closed 6 years ago

alexpott commented 6 years ago

Drupal 8.5 allows testing with PHPUnit 6 and requires it to test on PHP 7.2. This conflicts with the sebastian/diff dependency.

Whilst https://github.com/Lullabot/amp-library/pull/211 was closed for dropping PHP 5.5 and 5.6 support. How about we make the library have a wider set of dependencies it can work against? This PR passes locally on PHP 5.5, 5.6 and 7.1.

karens commented 6 years ago

I like this solution and tests pass. I haven't been involved in this project recently so I don't know if I have sufficient background yet to pull it in. But definitely thumbs up from me.

karens commented 6 years ago

The more I read the more convinced I am that we are going to have more and more problems on Drupal 8 unless we do something like this. We're getting close to the point where we can't support the wide range of dependencies of this library, Drupal 7, PHP 5, Drupal 8, and PHP 7. But with this patch we might buy some time.