search

Lullabot / amp-library

Convert HTML to AMP HTML and report HTML compliance with the AMP HTML specification
Other
382 stars 181 forks source link

Avoid instagram calls #236

Closed guiajlopes closed 4 years ago

guiajlopes commented 6 years ago

Hi,

Is that possible to avoid Instagram calls in the convertion? I see that we make the call only to get the dimensions, I think using the default ones should be fine. Maybe we should have a parameter to allow or not allow calls.

I have some pages with a lot of instagram embedes and the page load takes a lof of time because of that

m4olivei commented 4 years ago

I also noticed this today. I had one transaction Trace in New Relic wherethe Instagram call hung for over 2min. I think at least, the connection should have a timeout.

m4olivei commented 4 years ago

@guiajlopes Would you mind taking a look at #273 ?