search

Lullabot / amp-library

Convert HTML to AMP HTML and report HTML compliance with the AMP HTML specification
Other
381 stars 178 forks source link

support of PHP 7.3+ #278

Closed forgie1 closed 4 years ago

forgie1 commented 4 years ago

closes #276

karens commented 4 years ago

The update of Sebastian/diff to 4 will probably be a problem in some Drupal sites. Even a clean checkout of Drupal 9 is on Sebastian/diff 3.0.2.

I don't know the rational for that change.

karens commented 4 years ago

Requiring a minimum of 7.3 also means this might not work on Drupal 8. So I don't want to go that far. A minimum of php 7.2 is better.

karens commented 4 years ago

I'm adding 7.3 and 7.4 in #280. Don't want to drop 5.5 yet since there could still be Drupal 7 sites using it.