Lullabot / amp-library

Convert HTML to AMP HTML and report HTML compliance with the AMP HTML specification
Other
381 stars 178 forks source link

Allow sebastian/diff 4.x #296

Closed Berdir closed 2 years ago

Berdir commented 2 years ago

PHPUnit 9 requires version 4 and right now you can't install this on Drupal 9 if you are using phpunit 9.

Berdir commented 2 years ago

Workaround for this:

composer require sebastian/diff:"4.0.4 as 3.0.3" --no-update.

Haven't tested yet if this version actually works.

m4olivei commented 2 years ago

Just merged master here. Now that the test suite is passing again (https://github.com/Lullabot/amp-library/pull/298 and https://github.com/Lullabot/amp-library/pull/299), I used the same trick as suggested, ran the tests suite and all looks good.

Thanks!