search

Lullabot / amp-library

Convert HTML to AMP HTML and report HTML compliance with the AMP HTML specification
Other
381 stars 178 forks source link

Fix tests #299

Closed m4olivei closed 2 years ago

m4olivei commented 2 years ago

This PR ventures to fix the tests that are failing on master.

m4olivei commented 2 years ago

Hum, so it seems like the way the tests were designed to use an external image from Wikipedia is just not reliable. Looking at the last results, there isn't any reason why one version of PHP fails while the other(s) pass.

Need to find away to have meaningful tests here without relying on external images.

m4olivei commented 2 years ago

Ahh, much better.