Not working with php8.1.5

Lullabot / amp-library

Convert HTML to AMP HTML and report HTML compliance with the AMP HTML specification

Other

382 stars 181 forks source link

Not working with php8.1.5 #302

Open vikashgirnar opened 2 years ago

vikashgirnar commented 2 years ago

During inheritance of IteratorAggregate: Uncaught yii\base\ErrorException: Return type of QueryPath\DOMQuery::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /vendor/querypath/querypath/src/QueryPath/DOMQuery.php

criley commented 2 years ago

I am also running into this issue. Any word on getting it cleaned up?

luigimannoni commented 1 year ago

https://www.drupal.org/project/feeds_ex/issues/3299193

Here they swapped the querypath/querypath library with a more recent fork: https://github.com/arthurkushman/querypath