search

Lullabot / drainpipe

GNU General Public License v3.0
30 stars 13 forks source link

Switch phpstan to include phpstan.neon.dist #249

Open deviantintegral opened 11 months ago

deviantintegral commented 11 months ago

As I noted at https://github.com/Lullabot/drainpipe/pull/216, phpstan generally recommends and expects a .dist file to be committed to the repo, and phpstan.neon to be git ignored. As well, PHPStorm throws an error that phpstan.neon.dist doesn't exist.

Instead, lets:

  1. Copy the configuration as phpstan.neon.dist via composer scaffold.
  2. Get rid of -c in our task:static tests.
davereid commented 6 months ago

Yes, +1 to this, using a phpstan.neon.dist is preferred and what we provided via scaffolding on a shared install profile across several sites, which allows individual projects to still use their own phpstan.neon file that overrides/references the dist file already.

deviantintegral commented 4 months ago

Same type of issue as #238 .