Open davereid opened 6 months ago
https://www.npmjs.com/package/diff-lockfiles seems OK. A couple of things I noticed when I ran it:
package-lock.json
to a new format, version 3. diff-lockfiles
errored out on that difference. Not sure if that's b/c of different package-lock.jsonversion formats, or b/c it can't read older
package-lock.json` formats ๐คท . null
:$ npm run diff-lockfiles
> ibm-cms-project@1.0.0 diff-lockfiles
> diff-lockfiles --color HEAD~1 HEAD
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโคโโโโโโโโโโโโโโคโโโโโโโโโโโโโโ
โ ui.frontend.idl/package-lock.json โ โ โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ package โ old version โ new version โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/dns-packet/node_modules/ip โ 1.1.8 โ 1.1.9 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/follow-redirects โ 1.15.5 โ 1.15.6 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/ip โ 2.0.0 โ 2.0.1 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/webpack-dev-server/node_modules/ip โ 1.1.8 โ 1.1.9 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/astral-regex โ null โ 2.0.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/diff-lockfiles โ null โ 1.0.2 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/diff-lockfiles/node_modules/chalk โ null โ 5.3.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/diff-lockfiles/node_modules/commander โ null โ 11.1.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/diff-lockfiles/node_modules/lru-cache โ null โ 6.0.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/diff-lockfiles/node_modules/semver โ null โ 7.6.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/lodash.truncate โ null โ 4.4.2 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/require-from-string โ null โ 2.0.2 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/slice-ansi โ null โ 4.0.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/table โ null โ 6.8.1 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/table/node_modules/ajv โ null โ 8.12.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโผโโโโโโโโโโโโโโข
โ node_modules/table/node_modules/json-schema-traverse โ null โ 1.0.0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโงโโโโโโโโโโโโโโงโโโโโโโโโโโโโโ
Much like the composer.lock diff tables that get posted to pull requests, could Drainpipe also provide the same when package-lock.json files are changed? Likely it should also use a sticky pull request comment like proposed in https://github.com/Lullabot/drainpipe/issues/332 and only if the package-lock.json file has been changed.