Lullabot / drupal9ci

Command Line Interface for implementing Continuous Integration in Drupal 9
GNU General Public License v3.0
161 stars 55 forks source link

Installing drupal8ci moves existing composer dependencies to dev dependencies #4

Closed q0rban closed 6 years ago

q0rban commented 6 years ago

After creating a new drupal-project and installing drupal8ci, some of my dependencies have moved to dev dependencies.

diff --git a/composer.json b/composer.json
index 00f1e64..4ded610 100644
--- a/composer.json
+++ b/composer.json
@@ -17,18 +17,24 @@
     ],
     "require": {
         "composer/installers": "^1.2",
-        "cweagans/composer-patches": "^1.6",
         "drupal-composer/drupal-scaffold": "^2.2",
         "drupal/console": "^1.0.2",
         "drupal/core": "~8.4",
-        "drush/drush": "~8.0|^9.0.0-beta8",
         "vlucas/phpdotenv": "^2.4",
         "webflo/drupal-finder": "^1.0.0",
         "webmozart/path-util": "^2.3"
     },
     "require-dev": {
         "behat/mink": "~1.7",
+        "behat/mink-extension": "v2.2",
         "behat/mink-goutte-driver": "~1.2",
+        "behat/mink-selenium2-driver": "^1.3",
+        "bex/behat-screenshot": "^1.2",
+        "cweagans/composer-patches": "^1.6",
+        "drupal/coder": "^8.2",
+        "drupal/drupal-extension": "master-dev",
+        "drush/drush": "~8.1",
+        "guzzlehttp/guzzle": "^6.0@dev",
         "jcalderonzumba/gastonjs": "~1.0.2",
         "jcalderonzumba/mink-phantomjs-driver": "~0.3.1",
         "mikey179/vfsstream": "~1.2",
juampynr commented 6 years ago

I think that we could avoid this issue by removing composer-patches and requiring the other libraries in two composer statements. See my comments at https://github.com/juampynr/drupal8ci/pull/5 for further details.

juampynr commented 6 years ago

@q0rban, I did some testing and verified that removing the non-dev dependencies works https://github.com/juampynr/drupal8ci/pull/6.