Update Dockerfile to use 8.9-apache base image

Lullabot / drupal9ci

Command Line Interface for implementing Continuous Integration in Drupal 9

GNU General Public License v3.0

161 stars 55 forks source link

Update Dockerfile to use 8.9-apache base image #51

Closed m4olivei closed 4 years ago

m4olivei commented 4 years ago

We use the juampynr/drupal8ci docker image in our project and we're updating our production environments to PHP 7.3, as well as our version of Drupal to 8.9.5. Updating the base image here to use drupal:8.9-apache to accomodate both changes.

Also resolving a version conflict with behat/mink-extension, which good news! We no longer need to pin the version on that requirement as the relevant upstream issue has since been resolved and tagged.

juampynr commented 4 years ago

Thanks @m4olivei !

m4olivei commented 4 years ago

Thank you @juampynr !

m4olivei commented 4 years ago

Oops, now that the new build is available on Docker hub I re-ran the Circle CI job here on master and if failed:

https://app.circleci.com/pipelines/github/Lullabot/drupal8ci/3/workflows/a34defcd-d144-4a22-8185-7df723f09fdf/jobs/106

I have a theory it has to do with this recent change: https://github.com/docker-library/drupal/pull/176

The drupal/recommended-project is adjusted to use html/ instead of web/ so there is no effect to 8.8 and 8.9 except vendor (and composer.{json,lock}) moving to /var/www:

Just a guess, I'm trying to look into it with my limited Docker skilz.