search

Lullabot / drupal9ci

Command Line Interface for implementing Continuous Integration in Drupal 9
GNU General Public License v3.0
161 stars 55 forks source link

Issue #52 Change the working directory for the CircleCI job to be the same as the upstream Drupal image #53

Closed m4olivei closed 3 years ago

juampynr commented 3 years ago

Makes sense. Merged.

m4olivei commented 3 years ago

Sorry, I should have mentioned that this was still in progress.

This passes the jobs which is good, but I think it's becoming clear that we'll need to adjust the Docker image again to make things work for other projects. The upstream changes not only changed the working directory, but it also changed to use drupal/recommended-project. I believe that will mean that we no longer have to make adjustments to the Apache config here:

https://github.com/Lullabot/drupal8ci/blob/master/Dockerfile#L25-L26

I also wonder whether the CircleCI job for this repo should have a job for running unit / kernel tests as a way to test that the environment produced by the Docker image is ready to go. The build job goes as far as to run composer create-project and copy a demo test moduel into that structure, but that's all. Is that intentional?