search

Lullabot / drupal9ci

Command Line Interface for implementing Continuous Integration in Drupal 9
GNU General Public License v3.0
161 stars 55 forks source link

Issue #52 Change the working directory of the distributed CircleCI job #55

Closed byrond closed 3 years ago

byrond commented 3 years ago

Issue #52 resolved the working directory change for the drupal8ci repo, but we saw the same issue with a project created with the distributed CircleCI config. This makes the same change to that file.

byrond commented 3 years ago

You're welcome, @m4olivei! I'll update those now.

byrond commented 3 years ago

@m4olivei would the new Docker image affect Travis and GitLab? There are a few other instances of that path in this repo: https://github.com/Lullabot/drupal8ci/search?q=%22%2Fvar%2Fwww%2Fhtml%22

m4olivei commented 3 years ago

@byrond @juampynr Would be able to speak to that better than me. I suspect that would be the case, yeah. I've only used this in conjunction with CircleCI, so I can only speak for CirclCI.

juampynr commented 3 years ago

@byrond @m4olivei Totally, I think that replacing those paths like you point out in your link, @byrond, should fix it for Travis and GitLab. If you create a pull request for that I am happy to review and merge.

byrond commented 3 years ago

@juampynr it looks like the Travis configuration uses a different Docker image: wodby, so I'm inclined to leave that one alone. That just leaves two instances of RoboFile.php:

Should they be updated or left as-is?

juampynr commented 3 years ago

Correct @byrond! I think that the Travis setup is not affected by this change.

As for the other two files, I have not tested it manually but those two files do not seem to require any changes as they don't refer any absolute paths to the root directory where the project is checked out.