Closed fjgarlin closed 3 years ago
Thank you so much for updating these scripts @fjgarlin. I am keen on merging this pull request if it builds successfully for TravisCI and CircleCI. Let me know how you would like to handle it.
It is building successfully for those two so far. See last commit with green tick on the PRs I've been testing on:
Bear in mind that this is with Drupal 9. I haven't been testing these changes on Drupal 8 (end of life this year anyway).
I'm happy to open other PRs if I get to do Github actions or Gitlab integration, so I'm happy for you to merge this too.
Thanks Fran!
Regarding compatibility, I think that we can either do it later or simply focus on Drupal 9.
I just realised that I might need to change the name of this repo since it mentions drupal 8.
Worked! https://github.com/Lullabot/drupal9ci
GitHub takes care of redirections. This is great :-D
Awesome!
Addresses: https://github.com/Lullabot/drupal8ci/issues/64
Goal: least amount of changes to make it work on a D9 project.
Summary of the changes:
wget
line to allow URLs to contain&
without breaking.dist/common/web/modules/custom/demo_module/src/DemoModuleExampleService.php
to pass coding standards validation.dist/common/web/modules/custom/demo_module/tests/src/ExistingSiteJavascript/ExistingSiteTest.php
as official Javascript testing on Drupal is different (classes should extendDrupal\FunctionalJavascriptTests\WebDriverTestBase
)phpunit
configuration file only needed.core-dev
and the one needed forbehat
.trusty
toxenial
as it containsgd
andzip
packages by default.Progress