Lullabot / drupal9ci

Command Line Interface for implementing Continuous Integration in Drupal 9
GNU General Public License v3.0
161 stars 55 forks source link

Gitlab 9.x integration #68

Closed fjgarlin closed 3 years ago

fjgarlin commented 3 years ago

See it in action here: https://gitlab.com/fjgarlin/d9-lagoon/-/pipelines/284405524

Very similar to the changes done for Github actions. Bare minimum to get GitlabCI working with Drupal 9.

fjgarlin commented 3 years ago

@juampynr - The GitlabCI integration works but still no behat on this PR for Gitlab.

I started to work on the Github actions side of things for behat, but I'm hitting a bit of a blocker. I've got the downloading of the DB_DUMP_URL database sorted, but I'm struggling to get it to actually run behat because of this error.

I'm not sure if you can see this: https://github.com/fjgarlin/d9-lagoon/runs/2317781465


@javascript @api
Feature: Demo feature
  In order to test Drupal
  As an anonymous user
  I need to be able to see the homepage

  Scenario: Visit the homepage  # features/demo.feature:7
    Given I visit "/"           # Drupal\DrupalExtension\Context\MinkContext::assertAtPath()
      Could not open connection: Notice: Trying to access array offset on value of type null in /__w/d9-lagoon/d9-lagoon/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php line 156 (Behat\Mink\Exception\DriverException)
    Then I should see "Welcome" # Drupal\DrupalExtension\Context\MinkContext::assertPageContainsText()

--- Failed scenarios:

    features/demo.feature:7

I think it might be related to the launching of Chrome, or apache configuration... but to be honest I'm not sure at all.

I've tried:

juampynr commented 3 years ago

@fjgarlin I suggest we forget about Behat and we do Cypress.io. You could just remove the Behat tests first and then, if you feel for it, do the Cypress ones however you prefer at https://github.com/Lullabot/drupal9ci/issues/67.

fjgarlin commented 3 years ago

Sounds like a good plan because I'm running out of ideas on how to get around that issue.

I'll clean up the PR and once ready I'll mark it as Ready for review.

fjgarlin commented 3 years ago

I knew I was close. Behat now working for Github actions 🎉 : https://github.com/fjgarlin/d9-lagoon/actions/runs/738870134

So this PR contains:

Ready for review

juampynr commented 3 years ago

Yay!