Lullabot / gatsby-theme-adr

A Gatsby theme to generate a static site for ADRs
MIT License
12 stars 4 forks source link

fix: Sort by title if the date matches #65

Closed deviantintegral closed 1 year ago

deviantintegral commented 1 year ago

This fixes randomly changing the order of ADRs accepted on the same date on builds.

deviantintegral commented 1 year ago

This is new:

UNHANDLED REJECTION ENOSPC: System limit for number of file watchers reached,
watch '/var/lib/tugboat/packages/example/gatsby-config.js'

  Error: ENOSPC: System limit for number of file watchers reached, watch '/var/l
  ib/tugboat/packages/example/gatsby-config.js'
deviantintegral commented 1 year ago

@e0ipso there's no testing for this right now. If I add a record to the example directory, then it will show up in downstream sites too. Thoughts?

e0ipso commented 1 year ago

If I add a record to the example directory, then it will show up in downstream sites too. Thoughts?

I think that is not the case. The theme (/packages/gatsby-theme-adr) is independent from the example site (/packages/example).

What people download using npm is the theme. This is specified with the pkgRoot in semantic release.

e0ipso commented 1 year ago

I created https://github.com/Lullabot/gatsby-theme-adr/issues/66 as a follow up. I think this PR is safe to merge since it follows the official documentation.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.3.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: